HRTIM #192
HRTIM #192
Conversation
usbalbin
force-pushed
the
hrtim
branch
2 times, most recently
from
51e7def to
7994199
Compare
usbalbin
force-pushed
the
hrtim
branch
2 times, most recently
from
da010f2 to
cca48ab
Compare
|
stm32-hrtim is by no means "done", lots of missing features, there is a lot of weird trait bounds etc. Overall there is room for improvement. With that said I do think it is useful for what it does as is. @burrbull, @AdinAck and @boondocklabs what do you think is the best way to move this forward? Some steps in no particular order
What are your thoughts? :) |
|
I think first step is to release |
|
Wow, this clearly took a great deal of effort and I commend you as such. I do think this should eventually be included in Again, great stuff, thank you :) Let's make some buck regulators! Woohoo! |
|
Thanks :) So I'll just then? |
|
Done - stm32-hrtim |
Cargo.toml
Outdated
| stm32g474 = ["stm32g4/stm32g474", "cat3", "adc3", "adc4", "adc5", "hrtim", "stm32-hrtim/stm32g474"] | ||
| stm32g483 = ["stm32g4/stm32g483", "cat3", "adc3", "adc4", "adc5"] | ||
| stm32g484 = ["stm32g4/stm32g484", "cat3", "adc3", "adc4", "adc5"] | ||
| stm32g484 = ["stm32g4/stm32g484", "cat3", "adc3", "adc4", "adc5", "hrtim", "stm32-hrtim/stm32g484"] |
There was a problem hiding this comment.
How is this best done? I want the hrtim feature to be optional (just like can and cortic) but only available for stm32g474, stm32g484.
Is there any other/better way than
#[cfg(feature = "hrtim", not(any(feature = "stm32g474", feature = "stm32g484"))]
compile_error!("`hrtim` is only available for stm32g474 and stm32g484");
|
I'll merge this now unless someone objects :) |
|
Thank you all for all the help along the way! :) |
3 participants
We should probably wait until some sort of release before we merge this or we could perhaps put it behind some experimental feature flag(?)
Fixes #69